Move default Run 4 workflows to D121 by kpedro88 · Pull Request #49437 · cms-sw/cmssw

kpedro88 · 2025-11-21T19:15:01Z

PR description:

This PR is intended to complete the update of the default Run 4 geometry to D121, started in #48297.

PR validation:

runTheMatrix.py lists the correct workflows.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Not a backport. Can be backported upon request, but no immediate needs are foreseen.

cmsbuild · 2025-11-21T19:15:24Z

cms-bot internal usage

cmsbuild · 2025-11-21T19:16:38Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-49437/46917

There are other open Pull requests which might conflict with changes you have proposed:
- File Configuration/PyReleaseValidation/python/relval_steps.py modified in PR(s): 2026 RelVal Workflows #49419
- File Configuration/PyReleaseValidation/scripts/runTheMatrix.py modified in PR(s): [Do not merge] For cms-bot PR testing #48637, 2026 RelVal Workflows #49419

cmsbuild · 2025-11-21T19:17:01Z

A new Pull Request was created by @kpedro88 for master.

It involves the following packages:

CondTools/Geometry (db)
Configuration/PyReleaseValidation (pdmv)
Configuration/StandardSequences (operations)

@AdrianoDee, @Alejandro1400, @DickyChant, @JanChyczynski, @antoniovagnerini, @arunhep, @atpathak, @cmsbuild, @davidlange6, @fabiocos, @francescobrivio, @ftenchini, @mandrenguyen, @miquork, @perrotta can you please review it and eventually sign? Thanks.
@GiacomoSguazzoni, @JanChyczynski, @Martin-Grunewald, @PonIlya, @VinInn, @VourMa, @bsunanda, @dgulhan, @elusian, @fabiocos, @felicepantaleo, @makortel, @mmasciov, @mmusich, @mtosi, @rovere, @rsreds, @sameasy, @slomeo, @yuanchao this is something you requested to watch as well.
@ftenchini, @mandrenguyen, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

kpedro88 · 2025-11-21T19:17:04Z

Open questions:

@cms-sw/geometry-l2 I updated the CondTools scripts as we have done before. There are many scripts in Geometry/[Package]/test/python that also use D110. I am not sure which of these are actively used, so I have not addressed them. Please let me know if there are any that are particularly important to update.
@cms-sw/hlt-l2 I updated the ph2_hlt section of the matrix to D121 as well. Please let me know if this is not desired.

kpedro88 · 2025-11-21T19:17:32Z

 defaultDataSets['Run4D96']='CMSSW_13_1_0_pre1-130X_mcRun4_realistic_v2_2026D96noPU-v'
 defaultDataSets['Run4D98']='CMSSW_13_2_0_pre1-131X_mcRun4_realistic_v5_2026D98noPU-v'
 defaultDataSets['Run4D110']='CMSSW_15_1_0_pre5-150X_mcRun4_realistic_v1_STD_RegeneratedGS_Run4D110_noPU-v'
+defaultDataSets['Run4D121']=''


@cms-sw/pdmv-l2 is there anything that we can put here? I could not find any D121 samples in DAS.

Do we ever produce relvals with D121?

Not really. We can produce them.

In general I think that if we want to move definetly to D121, we'd need a validation campaign.

It should hopefully be very straightforward to validate, because the changes for all subdetectors are quite minor. We expect larger changes in 2026, but we wanted to complete this move first (which started in the summer).

Maybe @AdrianoDee could help to submit minbias relvals with D121 with existing release (e.g. 16_0_0_pre1 or pre2). Then, within the next few days, when dataset is available, this PR can be updated.

By the way, not sure how short matrix for PR test will work for now, as it will try to run D121+PU workflow, right?

Including pre2 relvals for this geometry in this PR would be ideal.

Indeed, a few tests may fail, but I think most do not include PU.

I've sent a set of D121 relvals here. Most of them are already done. So there you can use CMSSW_16_0_0_pre2-150X_mcRun4_realistic_v1_STD_RegeneratedGS_Run4D121_noPU-v.

For D121 validation itself, since it should be minor, I would proceed by just having both D110 and D121 samples produced for the incoming 16_0_0_pre3 campaign and have the validators inspect them there.

Thanks @AdrianoDee ! Your proposal for validation sounds good to me.

I shall update the ones in Geometry package

kpedro88 · 2025-11-21T19:17:47Z

please test

cmsbuild · 2025-11-21T20:24:10Z

-1

Failed Tests: RelVals
Size: This PR adds an extra 88KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-1d2dd6/49602/summary.html
COMMIT: 783293f
CMSSW: CMSSW_16_0_X_2025-11-21-1100/el8_amd64_gcc13
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/49437/49602/install.sh to create a dev area with all the needed externals and cmssw changes.

Failed RelVals

34634.999

----- Begin Fatal Exception 21-Nov-2025 20:57:54 CET-----------------------
An exception of category 'NoSecondaryFiles' occurred while
   [0] Constructing the EventProcessor
   [1] Constructing module: class=MixingModule label='mix'
Exception Message:
RootEmbeddedFileSequence no input files specified for secondary input source.
----- End Fatal Exception -------------------------------------------------

mmusich · 2025-11-24T08:32:54Z

test parameters:

workflows = ph2_hlt

mmusich · 2025-11-24T08:33:21Z

I updated the ph2_hlt section of the matrix to D121 as well. Please let me know if this is not desired.

this is going to be discussed this week at the upgrade HLT meeting.

kpedro88 · 2025-11-26T14:12:03Z

@cms-sw/pdmv-l2 @cms-sw/db-l2 please check and sign (aimed at pre3)

perrotta · 2025-11-26T14:55:22Z

@@ -3,7 +3,7 @@
 from Configuration.Eras.Era_Phase2C17I13M9_cff import Phase2C17I13M9


Just checking: is this era correct for D121?

Ah, you are right, it should be Phase2C22I13M9 because the calorimeter changes:

cmssw/Configuration/PyReleaseValidation/python/upgradeWorkflowComponents.py

Line 3876 in 1dbeb02

'Era' : 'Phase2C22I13M9',

I will propagate this update.

cmsbuild · 2025-11-26T15:13:54Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-49437/46988

There are other open Pull requests which might conflict with changes you have proposed:
- File Configuration/PyReleaseValidation/python/relval_steps.py modified in PR(s): slightly better control over HLT menus run in HIon relvals #49462
- File Configuration/PyReleaseValidation/scripts/runTheMatrix.py modified in PR(s): [Do not merge] For cms-bot PR testing #48637

cmsbuild · 2025-11-26T15:14:16Z

Pull request #49437 was updated. @AdrianoDee, @Alejandro1400, @DickyChant, @JanChyczynski, @antoniovagnerini, @arunhep, @atpathak, @cmsbuild, @davidlange6, @fabiocos, @francescobrivio, @ftenchini, @mandrenguyen, @miquork, @perrotta can you please check and sign again.

kpedro88 · 2025-11-26T15:15:19Z

please test

cmsbuild · 2025-11-26T18:03:35Z

+1

Size: This PR adds an extra 20KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-1d2dd6/49702/summary.html
COMMIT: 893cc1c
CMSSW: CMSSW_16_0_X_2025-11-26-1100/el8_amd64_gcc13
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/49437/49702/install.sh to create a dev area with all the needed externals and cmssw changes.

DAS Queries: The DAS query tests failed, see the summary page for details.

Comparison Summary

Summary:

No significant changes to the logs found
ROOTFileChecks: Some differences in event products or their sizes found
Reco comparison results: 6 differences found in the comparisons
Reco comparison had 4 failed jobs
DQMHistoTests: Total files compared: 47
DQMHistoTests: Total histograms compared: 3554205
DQMHistoTests: Total failures: 3
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3554182
DQMHistoTests: Total skipped: 20
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 46 files compared)
Checked 199 log files, 175 edm output root files, 47 DQM output files
TriggerResults: no differences found

perrotta · 2025-11-26T20:13:47Z

+db

AdrianoDee · 2025-11-26T20:24:13Z

+pdmv

cmsbuild · 2025-11-26T20:24:38Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @ftenchini, @sextonkennedy, @mandrenguyen (and backports should be raised in the release meeting by the corresponding L2)

mandrenguyen · 2025-11-26T20:47:22Z

+1

kpedro88 added 2 commits November 21, 2025 11:42

update relvals to use D121

450cc4f

update CondTools/Geometry to use D121

783293f

cmsbuild added this to the CMSSW_16_0_X milestone Nov 21, 2025

cmsbuild added db-pending operations-pending pending-signatures tests-pending orp-pending pdmv-pending code-checks-pending labels Nov 21, 2025

cmsbuild added code-checks-approved and removed code-checks-pending labels Nov 21, 2025

kpedro88 commented Nov 21, 2025

View reviewed changes

cmsbuild added tests-started and removed tests-pending labels Nov 21, 2025

cmsbuild added tests-rejected and removed tests-started labels Nov 21, 2025

add D121 relval string

aa1fe97

cmsbuild added tests-pending code-checks-pending and removed tests-rejected code-checks-approved labels Nov 24, 2025

cmsbuild added the tests-approved label Nov 25, 2025

perrotta reviewed Nov 26, 2025

View reviewed changes

update era for D121

893cc1c

cmsbuild added operations-pending tests-pending code-checks-pending and removed operations-approved tests-approved code-checks-approved labels Nov 26, 2025

cmsbuild added code-checks-approved and removed code-checks-pending labels Nov 26, 2025

cmsbuild added tests-started and removed tests-pending labels Nov 26, 2025

cmsbuild added operations-approved tests-approved and removed operations-pending tests-started labels Nov 26, 2025

cmsbuild added db-approved and removed db-pending labels Nov 26, 2025

kpedro88 mentioned this pull request Dec 5, 2025

Phase 2 geometry deprecation (pre-D110) #49563

Closed

mmusich mentioned this pull request Dec 16, 2025

use automatic upgrade Detector number redirection introduced in #49437 in the GPU matrix #49647

Merged

		@@ -3,7 +3,7 @@
		from Configuration.Eras.Era_Phase2C17I13M9_cff import Phase2C17I13M9

Conversation

kpedro88 commented Nov 21, 2025

PR description:

PR validation:

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Uh oh!

cmsbuild commented Nov 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cmsbuild commented Nov 21, 2025

Uh oh!

cmsbuild commented Nov 21, 2025

Uh oh!

kpedro88 commented Nov 21, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

srimanob Nov 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

AdrianoDee Nov 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

kpedro88 commented Nov 21, 2025

Uh oh!

cmsbuild commented Nov 21, 2025

Failed RelVals

Uh oh!

mmusich commented Nov 24, 2025

Uh oh!

mmusich commented Nov 24, 2025

Uh oh!

kpedro88 commented Nov 26, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

cmsbuild commented Nov 26, 2025

Uh oh!

cmsbuild commented Nov 26, 2025

Uh oh!

kpedro88 commented Nov 26, 2025

Uh oh!

cmsbuild commented Nov 26, 2025

Comparison Summary

Uh oh!

perrotta commented Nov 26, 2025

Uh oh!

AdrianoDee commented Nov 26, 2025

Uh oh!

cmsbuild commented Nov 26, 2025

Uh oh!

mandrenguyen commented Nov 26, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

cmsbuild commented Nov 21, 2025 •

edited

Loading

srimanob Nov 21, 2025 •

edited

Loading

AdrianoDee Nov 24, 2025 •

edited

Loading